NXP backend: Unify ExecuTorch and Neutron data format enums.#17066
Merged
MartinPavella merged 1 commit intopytorch:mainfrom Feb 6, 2026
Conversation
MartinPavella
added
module: nxp
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17066
Note: Links to docs will display an error until the docs builds have been completed. ❌ 9 New FailuresAs of commit d40397e with merge base 0b644f0 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Collaborator
Author
|
This PR depends on #17002, so only the last commit is relevant. |
robert-kalmar
approved these changes
Feb 3, 2026
jirioc
approved these changes
Feb 4, 2026
MartinPavella
force-pushed
the
nxg01483/feature/EIEX-408-replace-tensorformat-with-nodeformat
branch
from
769ae19 to
d40397e
Compare
Collaborator
Author
|
The failing checks seem unrelated, and the internal build passed. Merging. |
MartinPavella
deleted the
nxg01483/feature/EIEX-408-replace-tensorformat-with-nodeformat
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Originally, the NXP backend used the
NodeFormatenum to mark data formats (memory layouts) of ExecuTorch nodes, and theTensorFormatenum was used to mark the formats for Neutron IR tensors. However, these two classes fundamentally represent the same thing, and there is no need to keep them separated. Additionally, sometimes it was confusing as for which class to use which could result (and has resulted) in bugs.This PR unifies these 2 enums into 1.
Test plan
N/A
cc @robert-kalmar @JakeStevens @digantdesai